style: let the reader decide if something is simple or easy (upstream branch) #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So I went through the endless diff myself now, once again, just to be super sure I didn't mess up during the rebase. All seems good 🙏 @TC-MO can I have one more rubber stump here, please? (I know you've already approved the previous one, but GitHub won't allow me to merge this without explicit review.) |
honzajavorek
added
the
t-academy
TC-MO
approved these changes
Sep 10, 2024
|
Thank you so much!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1071. It's the same PR, but from an upstream branch, not from my fork. As discussed on Slack, this works around unauthorized npm token on CI.
I also rebased the original branch on top of current master, hopefully without mistakes. Otherwise the changes should be the same.